-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Add python code for notebook used in the parallel coordinate plot video #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Dec 8, 2021
ogrisel
reviewed
Dec 8, 2021
ogrisel
reviewed
Dec 8, 2021
ogrisel
reviewed
Dec 8, 2021
ogrisel
reviewed
Dec 8, 2021
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
reviewed
Dec 10, 2021
ogrisel
reviewed
Dec 10, 2021
ogrisel
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the title renaming suggestion above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447.
This PR partially moves the contents of the Hyperparameter tuning by randomized-search notebook to a new notebook that was used in the corresponding parallel coordinate plot video. The content that was suppressed is replaced with a brief discussion on the stability of the parameters found for the top performing models. This may hopefully serve as motivation for the need of a way to visualize the scores.
The idea is that the video and notebook will be displayed simultaneously within a split webpage. This may require FUN changes.