Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GBDT by HGBT and add wrap-up table #706

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Replace GBDT by HGBT and add wrap-up table #706

merged 4 commits into from
Sep 1, 2023

Conversation

ArturoAmorQ
Copy link
Collaborator

Fixes #448.

This PR reworks the Hyperparameter tuning for ensemble methods notebook to:

  • replace GBDT by HGBT (and adapt discussion)
  • add wrap-up table
  • prefer verbs in present mode

ogrisel
ogrisel approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few suggestions but otherwise LGTM!

python_scripts/ensemble_hyperparameters.py Outdated Show resolved Hide resolved
python_scripts/ensemble_hyperparameters.py Outdated Show resolved Hide resolved
python_scripts/ensemble_hyperparameters.py Outdated Show resolved Hide resolved
ArturoAmorQ and others added 2 commits September 1, 2023 09:57
@ArturoAmorQ @ogrisel
Apply suggestions from code review
ce1bdf9 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Improve format
c91bbb0
@ArturoAmorQ ArturoAmorQ merged commit 1506ae0 into INRIA:main Sep 1, 2023
3 checks passed
@ArturoAmorQ ArturoAmorQ deleted the ensemble_tuning branch September 1, 2023 08:14
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
@ArturoAmorQ
[ci skip] Replace GBDT by HGBT and add wrap-up table (#706) 1506ae0
fd6517e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wrap-up table for ensemble methods
2 participants
@ArturoAmorQ @ogrisel