fix SourcePositionImpl#addChild(CtElement, CtElement)

INRIA · Mar 31, 2018 · fd61958 · fd61958
1 parent 1aa7208
commit fd61958
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/main/java/spoon/support/reflect/cu/position/SourcePositionImpl.java b/src/main/java/spoon/support/reflect/cu/position/SourcePositionImpl.java
@@ -262,12 +262,16 @@ private static void addChild(CtElement parentElement, CtElement childElement) {
 			childSPI.checkValid();
 			SourcePositionImpl parentSP = SourcePositionUtils.getMyOrParentsSourcePosition(parentElement);
 			if (parentSP != null) {
-				int cmp = parentSP.compare(childSPI);
-				if (cmp == 0) {
-					parentSP.addChild(childSPI);
-				} else {
-					SourcePosition.class.getClass();
+				if (parentSP != childSPI) {
+					int cmp = parentSP.compare(childSPI);
+					if (cmp == 0) {
+						parentSP.addChild(childSPI);
+					} else {
+						SourcePosition.class.getClass();
+					}
 				}
+				//else these two elements has same instance of SourcePosition.
+				//It is probably OK
 			}
 			return;
 		}