-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.4.0: November 16, 2015 #400
Comments
Not exactly. A major version means incompatible API changes and a minor version means minor API changes but between each version (major or minor), we remove all deprecated methods (see Checklist). |
Well removing deprecated API is an API breaking change, which conflicts with the minor update convention of staying API compatible. Minor version can change API in non-breaking ways (adding API, deprecating API, but removing methods is definitly breaking. So either stick with the convention or prominently document that minor updates can break things. You could document the removal version in the javadoc of the depreceted method/class. Addition: A release process checklist is not a good place to document this |
@GerardPaligot I see it like @pschichtel.
and @monperrus answered:
|
I see your point. API compatibility is both syntactic (does it compile?) and behavioral (does it execute as before?). To this extent, even a bug fix may "break" existing code, this is the classical story of code exploiting a bug (it's not a bug, it's a feature). So my view is that "API breaking" is not binary (it's not only syntactic, it's not only bug fix vs removal), and the difference between a major and minor is the result of a qualified, well thought decision. that said, let's be very concrete: the removed methods seem to be secondary to us and only deserve a minor version. Are there any removed method on which you rely on, for which the deprecation period was too short? |
My point was: stick to the convention (minor will not break API consumers) or make it explicit through prominent documentation. |
You're right, we will improve the doc. --Martin |
Spoon 4.4.0 is published and on the way for Maven Central! I close this issue. |
Hi all,
The next release 4.4.0 is planned for Monday 16th November.
You can find the temporary changelog below:
Minor API Changes
SpoonModelBuilder
for a new one: refactor(api): Deprecates process method for a new one. #402Documentation
Fixes
CI
The text was updated successfully, but these errors were encountered: