Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query factory #1093

Merged
merged 6 commits into from
Jan 13, 2017
Merged

Query factory #1093

merged 6 commits into from
Jan 13, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

Implements

launcher.getFactory().Query().createQuery().map...
launcher.getFactory().Query().createQuery(anInput).map...

This PR is based on #1090. I will rebase it after #1090 is finished and merged.

@pvojtechovsky pvojtechovsky force-pushed the queryFactory branch 3 times, most recently from 6d6e2a2 to d9e5082 Compare January 8, 2017 15:47
@monperrus monperrus changed the title Query factory WIP Query factory Jan 11, 2017
@pvojtechovsky pvojtechovsky force-pushed the queryFactory branch 2 times, most recently from b4643ef to 8833c26 Compare January 11, 2017 21:12
@monperrus
Copy link
Collaborator

rebase?

@monperrus
Copy link
Collaborator

Interesting. By the way: what does an bound and empty query return by default? nothing or all children?

@pvojtechovsky
Copy link
Collaborator Author

what does an bound and empty query return by default?

I have added tests for this contract.

  • Bound query returns bound element
  • Unbound or null bound query returns no element

@monperrus monperrus changed the title WIP Query factory Query factory Jan 12, 2017
@monperrus
Copy link
Collaborator

Super.
Would you also add one or two sentences and remove the remaining new CtQueryImpl() in filters.md?

@monperrus
Copy link
Collaborator

[ERROR] /home/travis/build/INRIA/spoon/src/main/java/spoon/template/TemplateMatcher.java:455: error: @param name not found
[ERROR] * @param templateRoot

OK now we catch doc errors again in Travis, but it's a nightmare to locate them.

@pvojtechovsky
Copy link
Collaborator Author

Seems to be done from my side

@monperrus monperrus merged commit 7beb903 into INRIA:master Jan 13, 2017
@pvojtechovsky pvojtechovsky deleted the queryFactory branch January 21, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants