review FieldReferenceFunction, FieldScopeFunction, SubtypeFilter #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvojtechovsky
force-pushed
the
FieldReferenceFunction
branch
2 times, most recently
from
c47f41d
to
9455886
Compare
pvojtechovsky
changed the title
pvojtechovsky
force-pushed
the
FieldReferenceFunction
branch
from
d6bf91b
to
098eeac
Compare
pvojtechovsky
changed the title
pvojtechovsky
changed the title
|
Only this PR might need more tests, which would check package and public visible class fields in different packages. |
surli
reviewed
Jan 30, 2017
| .forEach(outputConsumer); | ||
| } | ||
| protected void searchForProtectedField(CtField<?> field, CtConsumer<Object> outputConsumer) { | ||
| //protected field can be referred from the scope of current top level type only |
There was a problem hiding this comment.
from the scope of current top level type only
and children
|
Seems good to me. I'm waiting for the new tests before merging. |
pvojtechovsky
force-pushed
the
FieldReferenceFunction
branch
from
8f9e79b
to
38ca424
Compare
pvojtechovsky
force-pushed
the
FieldReferenceFunction
branch
from
38ca424
to
7500c4c
Compare
|
The tests of field visibility in other classes and packages were added. It is finished from my point of view. |
|
Looks like Travis is ill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains FieldReferenceFunction, FieldScopeFunction, SubtypeFilter.
The main purpose is FieldReferenceFunction, which returns all the references to the field. Other two are helper classes which might be useful for others so they are public.
It depends on these PRs
The tests will be added later, because they share a lot with tests of #1136