review: feature: put generics information concerning method return types and parameters inside shadow classes

[surli]

No description provided.

[monperrus]

IMHO, you do not get the shadow class but the normal spoon model built from source. To obtain the shadow class
remove launcher.addInputResource("src/test/java/spoon/test/generics/testclasses/FakeTpl.java");

replace this one by factory.Interface().get(spoon.test.generics.testclasses.FakeTpl.class)

[surli]

I'm doing it line 1003: here, I'm testing that everything is as expected from the model built from source.

[monperrus]

OK, for a more readable test, it would be great to extract in an assertion and then you would write

// normal class
checkFakeTpl(factory.Interface().get("spoon.test.generics.testclasses.FakeTpl"))
//shadow class
checkFakeTpl(factory2.Interface().get(spoon.test.generics.testclasses.FakeTpl.class))

[surli]

OK

[surli]

Done.

[spoon-bot]

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-20170602.141932-6

New API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-SNAPSHOT

Detected changes: 2.

Change 1

Name	Element
Old	method void spoon.support.visitor.java.reflect.RtMethod::(java.lang.Class, java.lang.String, java.lang.Class, java.lang.reflect.TypeVariable<java.lang.reflect.Method>[], java.lang.Class[], java.lang.Class[], int, java.lang.annotation.Annotation[], java.lang.annotation.Annotation[][], boolean, boolean)
New	method void spoon.support.visitor.java.reflect.RtMethod::(java.lang.Class, java.lang.String, java.lang.Class, java.lang.reflect.Type, java.lang.reflect.TypeVariable<java.lang.reflect.Method>[], java.lang.Class[], java.lang.reflect.Type[], java.lang.Class[], int, java.lang.annotation.Annotation[], java.lang.annotation.Annotation[][], boolean, boolean)
Code	java.method.numberOfParametersChanged
Description	The number of parameters of the method have changed.
Breaking	source: breaking,

Change 2

Name	Element
Old	method void spoon.support.visitor.java.reflect.RtParameter::(java.lang.String, java.lang.Class<?>, spoon.support.visitor.java.reflect.RtMethod, java.lang.reflect.Constructor, int)
New	method void spoon.support.visitor.java.reflect.RtParameter::(java.lang.String, java.lang.Class<?>, java.lang.reflect.Type, spoon.support.visitor.java.reflect.RtMethod, java.lang.reflect.Constructor, int)
Code	java.method.numberOfParametersChanged
Description	The number of parameters of the method have changed.
Breaking	source: breaking,