Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: compile comments only if needed #1487

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

let JDK compiler parse comments only if they are needed.

Note: the CompilationUnitDeclaration#comments are needed only by JDTCommentBuilder whose usage is already restricted by ...getEnvironment().isCommentsEnabled()

@surli surli merged commit 87faf50 into INRIA:master Jul 31, 2017
@pvojtechovsky pvojtechovsky deleted the perfCompileCommentsOnlyIfNeeded branch July 31, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants