Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init RoleHandler lazily to pass when RoleHandler is generated #2068

Merged
merged 1 commit into from Jun 16, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

fix of #2063

@surli
Copy link
Collaborator

surli commented Jun 15, 2018

Thanks @pvojtechovsky for the fix! I just tried it with #2054 the test now works well, however the generated ModelRoleHandlers contains the following wrong imports:

import spoon.generating.meta.spoon.reflect.meta.impl.ListHandler;
import spoon.generating.meta.spoon.reflect.meta.impl.MapHandler;
import spoon.generating.meta.spoon.reflect.meta.impl.SetHandler;
import spoon.generating.meta.spoon.reflect.meta.impl.SingleHandler;

I had to remove them manually. I don't know if it's related with your changes here...

@pvojtechovsky
Copy link
Collaborator Author

I cannot imagine that this PR would cause the problems with import. I guess it is some other import related already merged PR.

@surli
Copy link
Collaborator

surli commented Jun 16, 2018

Ok I will open an issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants