Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary call to 'super' #2473

Merged
merged 1 commit into from Sep 18, 2018
Merged

refactor: remove unnecessary call to 'super' #2473

merged 1 commit into from Sep 18, 2018

Conversation

zielint0
Copy link
Contributor

No description provided.

@monperrus
Copy link
Collaborator

why is it unnecessary?

@zielint0
Copy link
Contributor Author

@monperrus
It makes code longer and brings no value at the same time.
The only useful super is: super("2"), super(1) etc. - when we pass parameter to constructor of superclass.

I fixed many of them #2274

@zielint0
Copy link
Contributor Author

@monperrus
To make reviewers life easy, I created a list of merged PRs.
If you want to see rationale or fact if something similar was merged or not, please take a look:
#2105

@monperrus monperrus merged commit e29dcae into INRIA:master Sep 18, 2018
@monperrus
Copy link
Collaborator

undone on master due to conflict with #1927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monperrus monperrus monperrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zielint0 @monperrus