Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Sonar Quality Gate badge #2935

Merged
merged 1 commit into from
Apr 8, 2019
Merged

chore: Add Sonar Quality Gate badge #2935

merged 1 commit into from
Apr 8, 2019

Conversation

surli
Copy link
Collaborator

@surli surli commented Apr 8, 2019

Add the Quality Gate badge from Sonar. Currently failing so it might push us to improve the code :)

Add the Quality Gate badge from Sonar. Currently failing so it might push us to improve the code :)
@monperrus monperrus merged commit 4232236 into master Apr 8, 2019
@monperrus
Copy link
Collaborator

thanks!

@monperrus
Copy link
Collaborator

What's the indicator considered to make it pass?

@surli
Copy link
Collaborator Author

surli commented Apr 8, 2019

The rules are specified there: https://sonarqube.ow2.org/quality_gates/show/1

Metric Over Leak Period Operator Warning Error
Coverage on New Code Always is less than   80.0%
Maintainability Rating on New Code Always is worse than   A
Reliability Rating on New Code Always is worse than   A
Security Rating on New Code Always is worse than   A

@surli surli deleted the surli-patch-1 branch April 8, 2019 12:42
@surli
Copy link
Collaborator Author

surli commented Apr 8, 2019

from what I see our main issue is the bugs spotted by SonarQube

Capture d’écran_2019-04-08_14-44-14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants