fix(MavenLauncher): allowing rebuilding of classpath #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
reviewed
Feb 24, 2020
|
Thanks for the PR, LGTM + see suggestion. |
Co-Authored-By: Martin Monperrus <monperrus@users.noreply.github.com>
|
LGTM! Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
MavenLauncherhas constructors with parameterforceRefresh, with the JavaDoc comment:However the value was actually never passed through to the
SpoonPommethod responsible for generating the classpath, as it was hardcoded to false. This is fixed and a methodrebuildClasspathis added toMavenLauncherto enable rebuilding of the classpath without instantiating a new launcher (or directly calling theSpoonPommethod). Tests for both use cases also added.