Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can freeNode be reported? #113

Closed
JohannaOtt opened this issue Sep 12, 2019 · 21 comments
Closed

How can freeNode be reported? #113

JohannaOtt opened this issue Sep 12, 2019 · 21 comments
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested requires change in TG The solution of the issue requires a change in TG
Milestone

Comments

@JohannaOtt
Copy link

I validated a dataset with Transport Network - Air data.
The test with the ID EIDd6fa7b64-9a2a-490e-aebe-7411a4610407 reports: "verify for each TransportNode that the geometry (a gml:Point) is located at a position that touches a TransportLink.centrelineGeometry (a gml:LineString or gml:Curve), i.e. that the node is at the start or end of a transport link. Otherwise report freeNode."
As the dataset contains AerodromeNode objects and no reference to other Transport Networks, that error/message is comprehensible and fits to the IR Requirement in Annex II, Section 7.9.3
What I am confused about is the part "Otherwise report freeNode". I cannot find any documentation or further information anywhere else on how to mark/identify 'freeNodes' in my data. Do you have any suggestions for that?

@josemasensio
Copy link
Contributor

Dear @JohannaOtt,
Thank you for your message, we will check what you mentioned and we will come back to you with a solution.

Best regards.

@josemasensio
Copy link
Contributor

Dear @JohannaOtt,

Please, could you use our contribution guidelines to help us more quickly locate what is causing this issue?

We will like to have the file you are using, the problem you have and if is possible, a screenshot of the issue. Thanks in advice, this information will be useful for us.

Best regards.

@JohannaOtt
Copy link
Author

@josemasensio Thank you for getting back to me. Unfortunately, there is not much information on how to start a discussion (which this issue is from my point of view) - if further information is needed, it might make sense to add it to the guidelines. Currently it is: "How to start a discussion
Please, make a short description about the topic you would like to discuss."

The data is confidential, if you give me an email address where I can send it, I will clarify with my customer if I am allowed to send it there.
The problem I have, is that the explanation of the test that fails (ID EIDd6fa7b64-9a2a-490e-aebe-7411a4610407) mentions I should report "freeNodes" to avoid the test failling and I don't see any information in the INSPIRE documents on how to report freeNodes.
I would like to know how I can realize the proposal the validator gives there. How can I mark a Node I am reporting as freeNode? Best case would be, if you even have an example of a GML file containing freeNodes.
Here is a screenshot of the message I am referring to:
grafik

@josemasensio
Copy link
Contributor

Dear @JohannaOtt
You can send them to inspire-helpdesk@bilbomatica.com.

Thank you, we will come back to you when a solution is provided.

@JohannaOtt
Copy link
Author

Thank you for the quick replies! I sent the data our via email.

@JohannaOtt
Copy link
Author

The email cannot be delivered with this error message:
We're writing to let you know that the group you tried to contact (inspire-helpdesk) may not exist, or you may not have permission to post messages to the group. A few more details on why you weren't able to post:

  • You might have spelled or formatted the group name incorrectly.
  • The owner of the group may have removed this group.
  • You may need to join the group before receiving permission to post.
  • This group may not be open to posting.

If you have questions related to this or any other Google Group, visit the Help Center at https://support.google.com/a/bilbomatica.es/bin/topic.py?topic=25838.

Thanks,

bilbomatica.es admins

@josemasensio
Copy link
Contributor

Dear @JohannaOtt

Apologise, is an internal problem, we will contact you when this is solved.

Regards

@josemasensio
Copy link
Contributor

Dear @JohannaOtt,

Please, could you try to send the credentials now?

Best regards.

@josemasensio
Copy link
Contributor

Dear @JohannaOtt,

We have already received the file. We will start to check why the error is occurring as soon as possible.

Best regards.

@fabiovin
Copy link
Collaborator

Dear @JohannaOtt ,
as you stated

that error/message is comprehensible and fits to the IR Requirement in Annex II, Section 7.9.3

the error is related to "Theme-specific Requirements – Geometry representation". Therefore, the validator checks that each node is present where a link connects or ends.
The name "freeNode" is just a label used in the ETS to identify these kinds of errors. There is no way to mark/identify 'freeNodes' in the data, also because the Data Specification not foreseen that.

In any case, looking at Figure 40 (pag. 120) of the Data Specification it seems that an AerodromeNode could be an "isolated" node, without any "direct" connection with any "network link".
Probably the "AerodromeNode" feature type should be a generalisation of the "TransportPoint" feature type instead of the "TransportNode" feature type. In this way, the aerodrome nodes would not fit into the IR Requirement about the geometry representation.
What do you think about this?

If this interpretation is correct, the AerodromeNode could be excluded from "Geometry representation" test.

It could be an interesting discussion for the INSPIRE Community Forum, as it may require an IR review. Could you please open it, if you think it's useful?

@JohannaOtt
Copy link
Author

Dear @fabiovin ,

Looking at Figure 40 in the Data Specification, I had the impression an AerodromeNode needs a Link to a different kind of TransportNetwork (road, railway,...) via a NetworkConnection. But I see now that it is only used for logical connections and therefore is not a Link.
This does indeed lead to the conclusion that AerodromeNodes could be isolated notes.
I opened this Thread for it in the Thematic Cluster: https://inspire.ec.europa.eu/forum/discussion/view/261634/tn-air-should-aerodromenode-be-a-transportnode-or-a-transportpoint

@fabiovin fabiovin added discussion This is a discussion about the Validator, any comment is welcome and removed under analysis labels Oct 7, 2019
@fabiovin fabiovin added this to For discussion in Validator issues Oct 10, 2019
@JohannaOtt
Copy link
Author

JohannaOtt commented Jan 24, 2020

@fabiovin As the post in the Thematic Cluster would need some support in order to make it to an actual change request to the JRC, please feel free to add any further information/input you have.

@dperezBM
Copy link
Collaborator

Dear all,

Since this issue had no interaction time ago, we decided to close it. Please feel free to open a new one if needed.

Thank you and best regards.

@JohannaOtt
Copy link
Author

As there is still no solution, I created INSPIRE-MIF/helpdesk#62

@fabiovin fabiovin reopened this Nov 10, 2021
@fabiovinci
Copy link
Collaborator

A schema change proposal to address the issue has been opened here.

@fabiovinci fabiovinci added user-to-fix Problem is present on user side user-fixed Problem solved on user side and removed user-to-fix Problem is present on user side user-fixed Problem solved on user side labels May 24, 2022
@fabiovinci fabiovinci added requires change in schema The solution of the issue requires a change in application schema and removed discussion This is a discussion about the Validator, any comment is welcome labels Jun 30, 2022
@fabiovinci fabiovinci moved this from For discussion to To do in Validator issues Jun 30, 2022
@fabiovinci fabiovinci removed this from To do in Validator issues Jan 25, 2023
@fabiovinci fabiovinci added non-breaking change The change makes tests less restrictive and it has no impact on resources already tested requires change in TG The solution of the issue requires a change in TG labels May 29, 2023
@MarcoMinghini MarcoMinghini added this to In progress in Validator issues May 29, 2023
@dperezBM
Copy link
Collaborator

dperezBM commented Jun 20, 2023

Dear @JohannaOtt,

The significantPoint= false exception has been applied for air related transport nodes and the solution is available in staging environment. Could you check if it is correct?

Regards

PS: @fabiovinci could you also check it?

@arantzaetxebarria arantzaetxebarria added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Jun 20, 2023
@MarcoMinghini MarcoMinghini moved this from In progress to Staging: for acceptance in Validator issues Jun 20, 2023
@fabiovinci
Copy link
Collaborator

I tested the solution and can confirm that the exception works as expected.

@arantzaetxebarria arantzaetxebarria added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Jun 21, 2023
@arantzaetxebarria arantzaetxebarria added this to the v2023.2 milestone Jun 21, 2023
@MarcoMinghini MarcoMinghini moved this from Staging: for acceptance to Staging: in release planning in Validator issues Jun 21, 2023
@jenriquesoriano jenriquesoriano added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jun 22, 2023
@MarcoMinghini MarcoMinghini moved this from Staging: in release planning to Production: latest release in Validator issues Jun 22, 2023
@JohannaOtt
Copy link
Author

@dperezBM I tried to test it but when trying to upload my file to the staging instance it fails
grafik

@fabiovinci
Copy link
Collaborator

Hi @JohannaOtt,

the fix was included in the 2023.2 release, so you can test it in the production instance.

@JohannaOtt
Copy link
Author

@fabiovinci Just tried to do so but that one is also running into an error
grafik

@fabiovinci fabiovinci removed this from Production: latest release in Validator issues Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested requires change in TG The solution of the issue requires a change in TG
Projects
None yet
Development

No branches or pull requests

7 participants