Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geology - Empty UOM Value Error #531

Closed
robblis opened this issue Mar 19, 2021 · 7 comments
Closed

Geology - Empty UOM Value Error #531

robblis opened this issue Mar 19, 2021 · 7 comments
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@robblis
Copy link

robblis commented Mar 19, 2021

Hi Validator Team,

We are in the process of validating our Geology theme.

We are getting the following issue when requesting the ge:Borehole feature in the Conformance Class 'INSPIRE GML application schemas'

XML document 'service.xml', Borehole 'geBorehole.1': The following properties of the feature have an empty value: uom. While this is valid against the XML schema, this is not valid according to the GML model. Please correct the process that generates the GML documents.

We feel that this may be an issue with the validator.

The attached XML returns the following XML
ge:boreholeLength
swe:Quantity
<swe:uom code="meters"/>
swe:value0.000000</swe:value>
</swe:Quantity>
</ge:boreholeLength>

However, the test wants to see the uom value either in an xlink:href attribute, which is not logical, or in the swe:uom element value itself. However, being in the node value itself causes the following schema error when running through the Xpath Assertion test.
The content of complex type definition 'swe:UnitReference' is 'empty'. This forbids any content for element swe:uom.

The test should check that no property of the feature is empty. But swe:uom is not a property of the feature.
The relevant property in this case is ge:boreholeLength, which is not empty. But it seems the test recursively checks all nested element, which maybe it should not do.

I've attached our returned XML file and the HTML Report.

Thanks for your help,
Robert

GE_BoreHole_TestArtifacts.zip

@project-bot project-bot bot added this to To do in Validator issues Mar 19, 2021
@carlospzurita
Copy link
Contributor

Dear @robblis

Thank you for opening this issue. We are checking the ETS and the results on the validator.

Kind regards.

@JohannaOtt
Copy link

Might be related to inspire-eu-validation/ets-repository#223

@fabiovin
Copy link
Collaborator

Dear @robblis,
you are right, the "swe:uom" element cannot have a value.

So, we need to add an exception for this element in the Conformance Class 'INSPIRE GML application schemas'.

@carlospzurita, since there are other similar cases, (e.g. inspire-eu-validation/ets-repository#223, this issue was opened in another repository but it seems solved, could you please verify?) it could be possible to add a generic exception, like *:uom?

Thank you @JohannaOtt for having linked a similar issue.

@iuriemaxim
Copy link

iuriemaxim commented Apr 7, 2021

We had a simmilar issue with UoM, but on OMOP, not on SWE. The incident that was fixed can be consulted here #206

While testing with these URLs, the test is passed:

https://inspire.meteoromania.ro/observedProperty/BUFR301
https://inspire.meteoromania.ro/observedProperty/GRIB650
https://inspire.meteoromania.ro/observedProperty/BUFR0-12-023
https://inspire.meteoromania.ro/observedProperty/BUFR0-12-023SF3PT24H
https://inspire.meteoromania.ro/observedProperty/BUFR0-13-003
https://inspire.meteoromania.ro/observedProperty/BUFR0-11-001SF32PT10M

I hope that these URLs to still pass the tests if any fix to this incident will be depolyed.

@arantzaetxebarria
Copy link
Collaborator

Dear @robblis

The ETS has been updated with a fix for this issue on the staging instance. Could you please test again and verify?
Thanks

@dperezBM dperezBM assigned robblis and unassigned carlospzurita Apr 22, 2021
@dperezBM dperezBM added the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Apr 22, 2021
@project-bot project-bot bot moved this from To do to Staging: for acceptance in Validator issues Apr 22, 2021
@robblis
Copy link
Author

robblis commented Apr 22, 2021

Hi @arantzaetxebarria,

We've retested against the fix in the staging instance. The test was successful.

Thanks,
Robert

@robblis robblis closed this as completed Apr 22, 2021
@dperezBM
Copy link
Collaborator

Dear @robblis,

Thank you for your feedback. We are going to keep the issue open in order to get tracked until the next release.

Best regards.

@dperezBM dperezBM reopened this Apr 23, 2021
@dperezBM dperezBM added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Apr 23, 2021
@project-bot project-bot bot moved this from Staging: for acceptance to Staging: in release planning in Validator issues Apr 23, 2021
@dperezBM dperezBM added this to the v2021.2 milestone Apr 23, 2021
@carlospzurita carlospzurita added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jun 16, 2021
@carlospzurita carlospzurita moved this from Staging: in release planning to Production: latest release in Validator issues Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
Validator issues
  
Production: latest release
Development

No branches or pull requests

7 participants