Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator doesn't accept Redirects (HTTP status code 302, 303) in data theme tests #559

Closed
hogredan opened this issue Jun 9, 2021 · 12 comments
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@hogredan
Copy link

hogredan commented Jun 9, 2021

In the German SDI, we use the national registry for referencing objects. A reference to the registry is made in the metadata, which then redirects to a GetFeatureById request. We use this concept to ensure persistence of IDs.

Example AdministrativeUnit (see attached file):

The object is accessible through the redirect and the registry correctly returns status code 302 in this case, but this is not accepted by the INSPIRE Validator (in this example Conformance Class Information accessibility, Administrative Units). See test report, test au.ia.b.4.

According to https://github.com/inspire-eu-validation/data-au#http-status-codes, redirects (status codes 301, 302 and 303) are not allowed because they are not supported by the OGC Web Services.

From our point of view, the statement "Redirects (status codes 301, 302, and 303) are in general not allowed as they are not supported by the OGC Web Service standards" is not correct.

For example, OGC API features allow HTTP status codes other than 200, see https://docs.ogc.org/is/17-069r3/17-069r3.html#_complete_definition.

Chapter 11.7.2 in the OGC Web Services Common Standard (https://portal.opengeospatial.org/files/?artifact_id=38867) specifies the following for handling HTTP status codes:
"Clients should recognize and handle other HTTP status codes as well, e.g., HTTP redirect codes (301, 302, 307)."

The problem, in our view, is that data is being tested here, but the test implicitly assumes that the data is provided via a WFS.

In principle we would support that OGC WFS services should not respond with HTTP redirect, but in this case the registry responds with the redirect and not the WFS.

We kindly ask for an adjustment of all data theme tests so that redirects (HTTP status code 301, 302, 303) are accepted.

@ghost
Copy link

ghost commented Jul 26, 2021

@carlospzurita Has this problem been solved in v2021.2 (15.06.2021)?

@ghost
Copy link

ghost commented Oct 7, 2021

@carlospzurita Has this problem been solved in v2021.3 (16.09.2021)?

@JohannaOtt
Copy link

@carlospzurita Are there any plans to handle re-directs in the future? I have a similar issue validating datasets that use codelist entries from the German codelist register:

The validator is reporting

The property 'LandCoverClassValue' has a value 'https://registry.gdi-de.org/codelist/de.adv-online.inspire/LandCoverClassValue/1' that cannot be retrieved using HTTP. Every code list value must be made available in an online registry.

But http://registry.gdi-de.org/codelist/de.adv-online.inspire/LandCoverClassValue/1 is re-directing to the https entry.

@JohannaOtt
Copy link

@fabiovinci What is the current state here?

@fabiovinci
Copy link
Collaborator

Dear @hogredan,

we are working on how to relax the test, at least for the Conformance Class Information accessibility, so that it accepts the redirection status codes for the first response and verifies that for the final response the code is 200.

We also need to verify how to implement the test since the change has an impact on all the data themes.

We will update you on the progress.

@fabiovinci
Copy link
Collaborator

Dear @JohannaOtt,
regarding the codelist, which codelist value are you using in your dataset?
Is it in http or https?

@JohannaOtt
Copy link

@fabiovinci It contains https values - example can be retrieved using this GetFeature request.
When executing the 2022.3 release with it, the Land Cover conformance class is not executed though
grafik

@dperezBM
Copy link
Collaborator

dperezBM commented Jan 9, 2023

Dear @hogredan,

The solution is available in staging instance . Could you check if it is correct?

@fabiovinci Could you also check it?

Regards.

@dperezBM dperezBM added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under analysis labels Jan 9, 2023
@fabiovinci
Copy link
Collaborator

Dear @JohannaOtt,
the error reported in your last comment is out of the scope of this issue.
I validated the xml downloaded from your WFS and the error reported is not present (see report: https://inspire.ec.europa.eu/validator/test-run/details.html?id=EID85aef4a7-b439-46eb-9c9c-b739beecddcd).
Could you please check and open a new issue if the error persists?

@JohannaOtt
Copy link

@fabiovinci Is still happening for me. I opened #905 for it now.

@hogredan
Copy link
Author

Dear @hogredan,

The solution is available in staging instance . Could you check if it is correct?

@fabiovinci Could you also check it?

Regards.

Dear @dperezBM ,

many thanks for the fix. I checked it and can confirm that the test works properly now.

@fabiovinci fabiovinci moved this from To do to Staging: for acceptance in Validator issues Jan 11, 2023
@fabiovinci
Copy link
Collaborator

Dear @hogredan,

thank you for confirmation.

During the fix of the error you reported, we detected that the same error was present in all Annex I data themes, so the same fix was applied also to the other themes.

We will include the fix in the next release.

@fabiovinci fabiovinci removed the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Jan 13, 2023
@fabiovinci fabiovinci added the solved Solution developed and accepted, not yet deployed label Jan 13, 2023
@fabiovinci fabiovinci added this to the v2023.0 milestone Jan 13, 2023
@fabiovinci fabiovinci moved this from Staging: for acceptance to Staging: in release planning in Validator issues Jan 13, 2023
@fabiovinci fabiovinci added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jan 25, 2023
@fabiovinci fabiovinci moved this from Staging: in release planning to Production: latest release in Validator issues Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
Validator issues
  
Production: latest release
Development

No branches or pull requests

7 participants