Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View services not fully tested in ETF Validator #703

Closed
petbod-lm opened this issue Jan 31, 2022 · 5 comments
Closed

View services not fully tested in ETF Validator #703

petbod-lm opened this issue Jan 31, 2022 · 5 comments
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Milestone
2022.2

Comments

@petbod-lm
Copy link

I am reviewing the ETF Validator reports for several view services published by Sweden.

I see that some WMS services only have the GetCapabilities_Operation test suite run by the ETF validator while another WMS services has 4 test suites run by the ETF validator (GetCapabilities_Operation, GetMap_Operation, LinkViewService_Operation and Language_Requirements).

A: The WMS service that only has the GetCapabilities_Operation suite run is
https://maps.lantmateriet.se/capabilities/inspire/basemap/wms/v1?request=GetCapabilities&service=WMS&version=1.3.0
(ETF Validator report: https://inspire.ec.europa.eu/validator/test-run/details.html?id=EIDbb945910-653f-4f69-8187-d8c8276f0ac7)

B: The WMS service that has all 4 test suites run is
http://maps.lantmateriet.se/capabilities/ortofoto/wms/v1.3?request=GetCapabilities&service=WMS&version=1.3.0
(ETF Validator report: https://inspire.ec.europa.eu/validator/test-run/details.html?id=EID0720b596-7d5a-4bf9-9f7d-587e7452b95f)

I have looked at the test suite logs and tests and I cannot see any error or exception that stops WMS service A from having the ETF suites run (GetMap_Operation, LinkViewService_Operation and Language_Requirements) compared to the test logs and results for WMS service B.

What prerequisite are these 3 test suites (GetMap_Operation, LinkViewService_Operation and Language_Requirements) depending on from the GetCapabilities_Operation suite?

Many thanks
/Pete
@project-bot project-bot bot added this to To do in Validator issues Jan 31, 2022
@arantzaetxebarria
Copy link
Collaborator

Dear @petbod-lm,

Thank you for your message. We are going to analyze the issue, we will come back to you once we have a response.

Best regards

@arantzaetxebarria arantzaetxebarria self-assigned this Feb 3, 2022
@LarsAll
Copy link

LarsAll commented Mar 1, 2022

Since moving to Geoserver 2.20.x with got this issue, the validation got to, and failed at, test AT47 (GetLegend) and seemingly stopped at that point.

@dperezBM dperezBM added the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Mar 11, 2022
@arantzaetxebarria arantzaetxebarria removed the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Mar 11, 2022
@arantzaetxebarria arantzaetxebarria mentioned this issue Mar 31, 2022
Closed
@arantzaetxebarria
Copy link
Collaborator

Dear @petbod-lm

One fix has been made against 618 and it seems that this issue is also solved. Could you please verify staging environment and let us know if all is correct? Thanks

Regards,

Arantza

@arantzaetxebarria arantzaetxebarria added the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Mar 31, 2022
@project-bot project-bot bot moved this from To do to Staging: for acceptance in Validator issues Mar 31, 2022
@petbod-lm
Copy link
Author

I can confirm that all 4 test suites are now run for the view service when I test in Staging.
thank you for resolving this issue.
/Pete

@fabiovinci
Copy link
Collaborator

Dear @petbod-lm,

thank you for the confirmation. We will include this fix in the next release.

@fabiovinci fabiovinci added solved Solution developed and accepted, not yet deployed non-breaking change The change makes tests less restrictive and it has no impact on resources already tested and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Mar 31, 2022
@fabiovinci fabiovinci added this to the 2022.2 milestone Mar 31, 2022
@fabiovinci fabiovinci moved this from Staging: for acceptance to Staging: in release planning in Validator issues Mar 31, 2022
@fabiovinci fabiovinci added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jun 22, 2022
@project-bot project-bot bot moved this from Staging: in release planning to Production: latest release in Validator issues Jun 22, 2022
@fabiovinci fabiovinci removed this from Production: latest release in Validator issues Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Projects
None yet
Milestone
2022.2
Development

No branches or pull requests
5 participants
@petbod-lm @fabiovinci @dperezBM @arantzaetxebarria @LarsAll