Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong polygon orientation reported for CRS EPSG:3045/EPSG:4258 #950

Closed
ulbrichtd opened this issue Apr 20, 2023 · 7 comments
Closed

Wrong polygon orientation reported for CRS EPSG:3045/EPSG:4258 #950

ulbrichtd opened this issue Apr 20, 2023 · 7 comments
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Milestone

Comments

@ulbrichtd
Copy link

Hi,

in Berlin our data is organized in CRS EPSG:25833. We use Geoserver+WFS with appschema extension to provide reprojected data in CRS EPSG:3045/EPSG:4258. The CRS EPSG:25833 uses east-north axis order while EPSG:3045/EPSG:4258 use north-east axis order.

We observed that the INSPIRE validator accepts polygons in EPSG:25833 and the validator reports wrong polygon orientation for EPSG:3045/EPSG:4258 in test "gmlas.d.10: Validate Geometries (1)". The error messages in these cases are "Error detected: Invalid polygon. Outer ring of polygon is clockwise within element MultiSurface" and "Error detected: Invalid polygon. Inner ring of polygon is counterclockwise within element MultiSurface".

Other software (FME GeometryValidator testing simple features) does not report errors in polygon orientation in these CRS.

Test reports for EPSG:3045/25833 (via staging instance of validator):

plu_entwicklung - epsg 3045.zip
plu_entwicklung - epsg 25833.zip

Links to the data:

Data in EPSG:3045

Data in EPSG:25833

Best regards & many thanks
Damian

@github-actions github-actions bot added this to To do in Validator issues Apr 20, 2023
@ulbrichtd ulbrichtd changed the title LandUse: Wrong orientiation reported for CRS EPSG:3045/EPSG:4258 LandUse: Wrong polygon orientiation reported for CRS EPSG:3045/EPSG:4258 Apr 20, 2023
@fabiovinci fabiovinci self-assigned this May 2, 2023
@fabiovinci
Copy link
Collaborator

Dear @ulbrichtd,

thank you for opening the issue and providing the related resources and sorry for the late reply.

This is a known issue for which we are testing the related solution in the BETA instance of the validator.

We will use your sample datasets for further testing and report back on the results.

@fabiovinci
Copy link
Collaborator

Dear @ulbrichtd,

we introduced a fix in the beta instance for the EPSG:3045 reference system, so the datasets with this reference system pass the geometry test if the axis order is N-E (Lat-Lon) and the related polygons contain counterclockwise outer rings and clockwise inner rings.

Could you please test the provided solution?

@fabiovinci fabiovinci assigned ulbrichtd and unassigned fabiovinci May 4, 2023
@fabiovinci fabiovinci added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under analysis labels May 4, 2023
@MarcoMinghini MarcoMinghini moved this from To do to Staging: for acceptance in Validator issues May 4, 2023
@ulbrichtd
Copy link
Author

ulbrichtd commented May 8, 2023

Hi Fabio,

thank you. I tested with the data. The validator reports now correct polygon orientation for EPSG:3045/EPSG:4258.

Unfortunately, test "lu-gml.a.1: Land Use feature in dataset" fails in the beta instance. The same data passes this test in the production instance of the validator. Please see attached reports Beta_vs_production-epsg_3045.zip.

Best regards,
Damian

@fabiovinci
Copy link
Collaborator

fabiovinci commented May 8, 2023

Dear @ulbrichtd,

thank you for the confirmation.
The error in the Beta instance is due to a temporary issue related to the redirection, which will be fixed soon.

@fabiovinci fabiovinci added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels May 8, 2023
@MarcoMinghini MarcoMinghini moved this from Staging: for acceptance to Staging: in release planning in Validator issues May 8, 2023
@JohannaOtt
Copy link

@fabiovinci Is that fix limited to LU or is there any chance that it also fixes the general issue in inspire-eu-validation/ets-repository#60?

@fabiovinci
Copy link
Collaborator

Hi @JohannaOtt,

the fix available in the BETA instance is a general fix for the issue related to polygon orientation.

@fabiovinci fabiovinci changed the title LandUse: Wrong polygon orientiation reported for CRS EPSG:3045/EPSG:4258 Wrong polygon orientiation reported for CRS EPSG:3045/EPSG:4258 Jun 13, 2023
@fabiovinci fabiovinci added this to the v2023.2 milestone Jun 15, 2023
@fabiovinci
Copy link
Collaborator

The fix has been made available in the Staging environment and will be included in the v2023.2 release.

@fabiovinci fabiovinci added the non-breaking change The change makes tests less restrictive and it has no impact on resources already tested label Jun 20, 2023
@jenriquesoriano jenriquesoriano added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jun 22, 2023
@MarcoMinghini MarcoMinghini moved this from Staging: in release planning to Production: latest release in Validator issues Jun 22, 2023
@jenriquesoriano jenriquesoriano changed the title Wrong polygon orientiation reported for CRS EPSG:3045/EPSG:4258 Wrong polygon orientation reported for CRS EPSG:3045/EPSG:4258 Aug 18, 2023
@fabiovinci fabiovinci removed this from Production: latest release in Validator issues Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested
Projects
None yet
Development

No branches or pull requests

4 participants