Entity creation, simplify error handling, format and lint code #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the code does not create any new entities in maltego if tags are available for the requested address. This is because the triple returned by
get_address_details
andget_entity_details
was not handled properly (seeGraphSense-Maltego-transform/api/utils.py
Line 91 in d3adadc
GraphSense-Maltego-transform/transforms/ToTags.py
Lines 45 to 54 in d3adadc
Whenever tags where available the error handling code simply printed a Maltego UI Msg but did not add the properties to the Maltego entity.
This PR should fix this issue. I also simplified the error handling code a bit, to avoid duplication.
Hope this helps.