Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab logout #479

Open
prasadtalasila opened this issue Jan 22, 2024 · 1 comment
Open

Gitlab logout #479

prasadtalasila opened this issue Jan 22, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@prasadtalasila
Copy link
Contributor

The current codebase does not logout of gitlab. Does using oauth revoke API help?

@prasadtalasila prasadtalasila added bug Something isn't working enhancement New feature or request labels Jan 22, 2024
@prasadtalasila prasadtalasila added this to the Release v0.5.0 milestone Jan 22, 2024
@prasadtalasila
Copy link
Contributor Author

Even the SessionStorage of the react website is not cleared. This needs to be cleared as well.

The following changes are needed:

  1. Account.jsx - exporting the wrong react component
  2. Authentication.ts - signOut needs to have the required signout functionality. The react-oidc-context package already has
export declare interface AuthContextProps extends AuthState {
    /**
     * UserManager functions. See [UserManager](https://github.com/authts/oidc-client-ts) for more details.
     */
    readonly settings: UserManagerSettings;
    readonly events: UserManagerEvents;
    clearStaleState(): Promise<void>;
    removeUser(): Promise<void>;
    signinPopup(args?: SigninPopupArgs): Promise<User>;
    signinSilent(args?: SigninSilentArgs): Promise<User | null>;
    signinRedirect(args?: SigninRedirectArgs): Promise<void>;
    signinResourceOwnerCredentials(args: SigninResourceOwnerCredentialsArgs): Promise<User>;
    signoutRedirect(args?: SignoutRedirectArgs): Promise<void>;
    signoutPopup(args?: SignoutPopupArgs): Promise<void>;
    signoutSilent(args?: SignoutSilentArgs): Promise<void>;
    querySessionStatus(args?: QuerySessionStatusArgs): Promise<SessionStatus | null>;
    revokeTokens(types?: RevokeTokensTypes): Promise<void>;
    startSilentRenew(): void;
    stopSilentRenew(): void;
}

signouSilent() and revokeTokens() may need to be invoked to complete the signout process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

1 participant