Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables in docker installation #748

Open
prasadtalasila opened this issue May 8, 2024 · 1 comment
Open

Rename variables in docker installation #748

prasadtalasila opened this issue May 8, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@prasadtalasila
Copy link
Contributor

prasadtalasila commented May 8, 2024

The .env file has the following format:

DTAAS_DIR='/User/xxx/DTaaS'
SERVER_DNS='foo.com'
OAUTH_URL='http://foo.com'
CLIENT_ID='xxx'
CLIENT_SECRET='xxx'
OAUTH_SECRET='random-secret-string'
CLIENT_CONFIG='/User/xxx/DTaaS/deploy/config/client/env.trial.js'
username1='user1'
username2='user2'

While the names of CLIENT_ID and CLIENT_SECRET are technically correct from OAuth providers point of view, they are confusing to the admin of DTaaS. From admin's point of view, these are variables for traefik forward-auth and probably renamed to SERVER_ID and SERVER_SECRET.

@prasadtalasila prasadtalasila added enhancement New feature or request good first issue Good for newcomers labels May 8, 2024
@prasadtalasila
Copy link
Contributor Author

It is also better to rename deploy/config/lib.docker to just deploy/config/lib

@prasadtalasila prasadtalasila added this to the Release v0.6.0 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant