Feat/13 month calendar week number #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2024 14:30
… week number if set true from configuration
…-calendar into feat/13-month-calendar-week-number
AhsanAyaz
requested changes
Mar 25, 2024
| result = 1; | ||
| } | ||
| } | ||
|
|
||
| if (ycConfig.periodWeekNumber) { | ||
| date.setHours(12, 0, 0, 0); | ||
| const diff = (date.getTime() - firstWeekFirstDate.getTime()) / 86400000; |
There was a problem hiding this comment.
Can we move this constant into a const variable to show that this number means?
projects/angular-year-calendar/src/lib/pipes/week-number/week-number.pipe.ts
Outdated
Show resolved
Hide resolved
projects/angular-year-calendar/src/lib/pipes/week-number/week-number.pipe.ts
Outdated
Show resolved
Hide resolved
AhsanAyaz
requested changes
Mar 26, 2024
| transform(date: Date, ycConfig: YCConfig, year): any { | ||
| const dateClone = new Date(date); | ||
| const {firstWeekMonth, weekStartsOn, forceWeek, forceWeekDate} = ycConfig; | ||
| const oneDay = 86400000; // milliseconds in a day |
There was a problem hiding this comment.
Can we rename this? We shouldn't need a comment to explain a variable name. The variable name should be self explanatory.
Suggested change
| const oneDay = 86400000; // milliseconds in a day | |
| const millisecondsInADay = 86400000; |
projects/demo/src/app/app.module.ts
Outdated
| import { ExampleSectionComponent } from "./components/example-section/example-section.component"; | ||
| import { ConfigSideBarComponent } from "./components/config-side-bar/config-side-bar.component"; | ||
| import { YearCalendarModule } from "@iomechs/angular-year-calendar"; | ||
| // import { YearCalendarModule } from "../../../angular-year-calendar/src/public-api"; |
There was a problem hiding this comment.
We can remove this import since we're not using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.