Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing addParameterValue in Assay #16

Closed
feserm opened this issue Feb 21, 2022 · 1 comment
Closed

Missing addParameterValue in Assay #16

feserm opened this issue Feb 21, 2022 · 1 comment

Comments

@feserm
Copy link
Member

feserm commented Feb 21, 2022

When building samples for the assay file, there is not option to add Parameter Values. Instead you are able to add Factor Values.

https://ipk-bit.github.io/isa4j/javadoc/de/ipk_gatersleben/bit/bi/isa4j/components/Sample.html
https://isa-specs.readthedocs.io/en/latest/isatab.html#assay-table-file

@Thyra
Copy link
Member

Thyra commented Feb 22, 2022

Hey, Parameters are only ever attached to Processes, not Process Inputs or Outputs like Sources or Samples. Samples instead can carry Characteristics and Factors. From the link you provided:

A Sample MUST be provided as the first node in the experimental graph, indicated with the column heading Sample Name.

Protocol REF columns MUST be used to indicate Process nodes, with values referencing protocols declared in the Investigation file. The Protocol REF column MAY be qualified with Parameter Value [<parameter term>]

It is even more clear from the JSON schemas (https://isa-specs.readthedocs.io/en/latest/isajson.html#sample-schema-json):

{
    "$schema": "http://json-schema.org/draft-04/schema",
    "title" : "ISA sample schema",
    "description" : "JSON-schema representing a sample in the ISA model. A sample represents a major output resulting from a protocol application other than the special case outputs of Extract or a Labeled Extract.",
    "type": "object",
    "properties" : {
        "@id": { "type": "string", "format": "uri" },
        "name" : { "type" : "string" },
        "characteristics" : {
            "type" : "array",
            "items" :  {
                "$ref": "material_attribute_value_schema.json#"
            }
        },
        "factorValues" : {
            "type" : "array",
            "items" : {
                "$ref" : "factor_value_schema.json#"
            }
        },
        "derivesFrom": {
            "type" : "array",
            "items" : {
                "$ref": "source_schema.json#"
            }
        }
    },
    "additionalProperties": false
}

Please reopen the issue if I misunderstood you.

@Thyra Thyra closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants