111 centos 8 #115
Merged
111 centos 8 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r centos8 just yet
pdurbin
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
This was referenced Sep 30, 2019
|
@donsizemore I looked as of e146bd6 and this pull request is looking good. Should we include in this pull request change to ec2-create-instance.sh where we add a switch for which AMI to spin up? |
|
@pdurbin let's make that a separate issue/PR? it'll require two flags, one to choose the AMI and one to choose the size (not all size/AMI combos play together) |
|
@donsizemore that's fine. I'm happy to create the issues about AMI selection etc. For this pull request I'm fine with you just merging it if you're feeling pretty good about it. We can always back it out if things go sideways. 😄 |
|
@donsizemore you have my blessing to merge. 😄 |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to Done 🚀
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rhel/centos8 requires postgresql10+; everything else required only minor tweaks.