Overload method void uploadFile(String doi, File file); to void uploadFile(String doi, InputStream is, String filename); #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I must say that I tried all the tests before and after my modifications and I found that 3 tests fail, before and after my modifications, so I deduced that these are not my fault. I tried against this dataverse instance |
otter606
reviewed
Nov 16, 2022
src/main/java/com/researchspace/dataverse/api/v1/DatasetOperations.java
Outdated
Show resolved
Hide resolved
otter606
reviewed
Nov 16, 2022
src/main/java/com/researchspace/dataverse/api/v1/DatasetOperations.java
Outdated
Show resolved
Hide resolved
otter606
reviewed
Nov 16, 2022
| * | ||
| * @param doi Identifier of the dataset that we are sending the data to. | ||
| * @param file Stream of data to the contents of the file to upload. | ||
| * @param filename Name of the file. |
There was a problem hiding this comment.
If the input stream doesn't come from a file, but instead from a network or whatever, then the 'file' terminology isn't quite accurate. I think 'filename' is the name you want it to appear as in Dataverse, is that correct?
otter606
reviewed
Nov 16, 2022
| @@ -224,6 +225,23 @@ public void uploadFile (String doi, File file) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public void uploadFile(String doi, InputStream file, String filename) { | |||
| FileUploader uploader = new FileUploader(); | |||
There was a problem hiding this comment.
Could uploadFile(string, file) call
uploadFile(doi, new FileInputStream(file), file.getName())
in order to reduce duplication?
otter606
reviewed
Nov 16, 2022
…d to previous changes in this PR: Changed name of variable and changed javadoc from uploadFile method, delegated implementation of one of the uploadFile implementation to the other to avoid duplication, split line of deposit for being too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally here is my PR to solve #12