-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native file upload #16 #23
Conversation
src/main/java/com/researchspace/dataverse/entities/ObjectOrStringMessageDeserializer.java
Outdated
Show resolved
Hide resolved
}; | ||
return getDatasetFileList(metadata, dsIdentifier, resource); | ||
} | ||
// TODO stream read twice??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by read stream twice? Do you have any problem? We can discuss it if you want.
Generally, I have taken a look into the code and it looks promising :D :D As soon as you do the merge I will try out the new functionalities. I will post how it goes if you want. Thank you! |
src/main/java/com/researchspace/dataverse/http/DataverseOperationsImplV1.java
Outdated
Show resolved
Hide resolved
successful post of file
add overloaded method to add input stream fix tests Update src/main/java/com/researchspace/dataverse/entities/ObjectOrStringMessageDeserializer.java docs: javadocs Update src/main/java/com/researchspace/dataverse/http/DataverseOperationsImplV1.java remove obsolete comment
e5d5261
to
d4befed
Compare
@AleixMT here is a PR of intended changes.
It supports upload of file using native API, not Sword.
Please have a look at the new tests in DatasetOperationsTest such as
uploadFileToDataSetWithNativeApiBytes
to see how to use it.Any comments welcome