Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit dataset use case #151

Merged
merged 14 commits into from
May 13, 2024
Merged

Edit dataset use case #151

merged 14 commits into from
May 13, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Apr 24, 2024

What this PR does / why we need it:

Adds the dataset editing use case to the package.

This use case will be used by the SPA dataset edit form, but could be useful for any other consumer application that requires updating dataset metadata.

The use case reuses the logic from the dataset creation use case, such as field validation, which is why I refactored the code to avoid duplication.

Which issue(s) this PR closes:

Related Dataverse PRs:

  • None

Suggestions on how to test this:

Visual inspection of the code and GitHub actions.

Additional documentation:

None

@GPortas GPortas marked this pull request as ready for review May 1, 2024 10:47
@GPortas GPortas added Size: 10 A percentage of a sprint. 7 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: Edit Dataset Page labels May 1, 2024
@GermanSaracca GermanSaracca self-assigned this May 2, 2024
Copy link
Contributor

@GermanSaracca GermanSaracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks solid and tests are passing perfectly.
This use case is for updating only the metadata field values of a dataset right?

@GPortas
Copy link
Contributor Author

GPortas commented May 3, 2024

Code looks solid and tests are passing perfectly. This use case is for updating only the metadata field values of a dataset right?

Thanks for your review. Yes, only the metadata.

@GermanSaracca GermanSaracca removed their assignment May 3, 2024
@ekraffmiller ekraffmiller self-assigned this May 13, 2024
@ekraffmiller
Copy link
Contributor

looks good! ran the tests in my environment and all are passing

@ekraffmiller ekraffmiller merged commit fda27f7 into develop May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 10 A percentage of a sprint. 7 hours. SPA: Edit Dataset Page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create use case for editing a dataset
3 participants