Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get file counts use case with search criteria #93

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Oct 9, 2023

What this PR does / why we need it:

Allows to get file counts specifying search criteria, required for the SPA files tab.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

getDatasetFilesTotalDownloadSize IT are failing due to unmerged PR: IQSS/dataverse#9960, so I have skipped them in the code so the GitHub action can deploy the package.

Suggestions on how to test this:

  • Visual inspection of the code
  • Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

Add FileSearchCriteria to GetFileCounts use case

Additional documentation:

None

@GPortas GPortas marked this pull request as ready for review October 10, 2023 11:23
@GPortas GPortas added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Oct 10, 2023
@MellyGray MellyGray self-assigned this Oct 10, 2023
@MellyGray MellyGray moved this from Ready for Review ⏩ to In Review 🔎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Oct 10, 2023
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the refactor to FileSearchCriteria and FileOrderCriteria, makes much more sense now 👌

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from In Review 🔎 to Ready for QA ⏩ Oct 10, 2023
@MellyGray MellyGray removed their assignment Oct 10, 2023
@kcondon kcondon self-assigned this Oct 13, 2023
@kcondon
Copy link
Contributor

kcondon commented Oct 16, 2023

@GPortas Github actions passes but publish-gpr fails. Not sure whether this is ok to merge.

@kcondon kcondon merged commit 5866778 into 86-get-files-total-download-size Oct 17, 2023
2 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants