Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete testsuite for upload / creation #4

Closed
4 of 6 tasks
leeper opened this issue Nov 8, 2015 · 12 comments
Closed
4 of 6 tasks

Complete testsuite for upload / creation #4

leeper opened this issue Nov 8, 2015 · 12 comments

Comments

@leeper
Copy link
Member

leeper commented Nov 8, 2015

edit: jump to list of functions to test

@leeper leeper added this to the Version 1.0 (CRAN Release) milestone Nov 8, 2015
leeper added a commit that referenced this issue Nov 9, 2015
leeper added a commit that referenced this issue Apr 5, 2016
leeper added a commit that referenced this issue Jun 12, 2017
leeper added a commit that referenced this issue Jun 15, 2017
@pdurbin
Copy link
Member

pdurbin commented Nov 4, 2019

* Use test server

Very recently we set up a Jenkins server that spins up Dataverse on AWS EC2. (And that EC2 instance is terminated later that day.) If we want, we could close this issue and focus on testing over at #22. I'm fine with whatever. 😄

@wibeasley
Copy link
Contributor

wibeasley commented Jan 4, 2020

Approximate order of functions to write tests for. The later functions tend to depend on the earlier ones. The classification & order will be updated as I learn more.

Downloading Structure & Metadata

  • get_dataverse()
  • dataverse_contents()
  • list_datasets()
  • get_dataset()
  • dataset_metadata()
  • dataset_files()
  • get_file_metadata()

Downloading Files

  • get_file()

Creating & Publishing

  • create_dataset()
  • create_dataverse()
  • initiate_sword_dataset()
  • publish_dataset()
  • publish_dataverse()
  • publish_sword_dataset()

Uploading

  • add_dataset_file()
  • add_file()
  • update_dataset()
  • update_dataset_file()

Deleting

  • delete_dataset()
  • delete_dataverse()
  • delete_file()
  • delete_sword_dataset()

I haven't studied/classified yet

  • dataset_atom()
  • dataset_statement()
  • dataset_versions()
  • dataverse_metadata()
  • dataverse_search()
  • get_facets()
  • get_user_key()
  • service_document()
  • set_dataverse_metadata()

wibeasley added a commit that referenced this issue Feb 2, 2020
wibeasley added a commit that referenced this issue Feb 19, 2020
wibeasley added a commit that referenced this issue Feb 24, 2020
ref #4
@wibeasley wibeasley pinned this issue Mar 20, 2020
wibeasley added a commit that referenced this issue Mar 20, 2020
@wibeasley wibeasley mentioned this issue Apr 21, 2020
wibeasley added a commit that referenced this issue Apr 22, 2020
@kuriwaki kuriwaki removed this from the Version 1.0 (CRAN Release) milestone Dec 21, 2021
@kuriwaki kuriwaki changed the title Add test suite Add complete test suite (testthat) Dec 21, 2021
@kuriwaki
Copy link
Member

See also #40 for discussion on how we will use a live Dataverse for this task. Will close when more of the checklist ^ is completed.

@kuriwaki kuriwaki changed the title Add complete test suite (testthat) Complete testsuite for upload / creation Jun 10, 2022
@pdurbin
Copy link
Member

pdurbin commented Apr 28, 2023

@kuriwaki @wibeasley I just posted a message intended mostly for @JR-1991 about newly published containers for API testing: https://dataverse.zulipchat.com/#narrow/stream/377090-python/topic/containers.20for.20API.20testing

You're very welcome to join Zulip and discuss! (That's the "python" stream but I'm happy to create more streams if you want one.)

Thanks, as always, for all of your contributions to the dataverse package! ❤️ 🎉 🚀

@pdurbin
Copy link
Member

pdurbin commented May 1, 2023

@kuriwaki
Copy link
Member

kuriwaki commented May 1, 2023

Great to see it in action! This github actions setup looks like the ideal setup for our test environment. And thank you, @JR-1991.

@pdurbin
Copy link
Member

pdurbin commented May 2, 2023

@kuriwaki I'm getting a strange error when I upload a file: https://dataverse.zulipchat.com/#narrow/stream/377090-python/topic/containers.20for.20API.20testing/near/355010545

Here's my workflow file if you want to try to iterate on it: https://github.com/IQSS/dataverse-sample-data/actions/runs/4856813925/workflow

I am able to create a collection and a dataset, at least, so maybe you could try adding tests for that.

@wibeasley
Copy link
Contributor

This looks awesome.

@pdurbin
Copy link
Member

pdurbin commented May 4, 2023

@pdurbin
Copy link
Member

pdurbin commented Oct 20, 2023

Beep boop.

These days I'm actively using https://github.com/gdcc/api-test-runner to spin up Dataverse in containers using GitHub Actions (the "develop" workflow, usually). You're very welcome to copy it, if it helps. After I spin up Dataverse, I run our (Java-based) API test suite against it.

Longer term we are working on https://github.com/gdcc/dataverse-action which (once it's ready), we'll publish to the GitHub Marketplace.

This is all on topic for our weekly Containerization Working Groups meetings, if you're interested! https://ct.gdcc.io

@pdurbin
Copy link
Member

pdurbin commented Jan 5, 2024

A new PR from pyDataverse that spins up Dataverse in containers locally:

@kuriwaki
Copy link
Member

I suggest we use #134 for an updated discussion ghaction and pyDataverse. Thanks @pdurbin for the updates about pyDataverse and containers here.

@kuriwaki kuriwaki closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
@kuriwaki kuriwaki unpinned this issue Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants