Skip to content

add missing parameter to Dataset component #1648

add missing parameter to Dataset component

add missing parameter to Dataset component #1648

Triggered via push July 10, 2024 16:25
Status Failure
Total duration 2m 22s
Artifacts

lint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 11 warnings
lint: tests/component/sections/dataset/Dataset.spec.tsx#L17
'DatasetMockRepository' is defined but never used
lint
Process completed with exit code 1.
lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: packages/design-system/src/lib/components/select-multiple/SelectMultiple.tsx#L57
React Hook useEffect has missing dependencies: 'isFirstRender' and 'onChange'. Either include them or remove the dependency array. If 'onChange' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: src/sections/collection/datasets-list/useDatasets.tsx#L50
React Hook useEffect has a missing dependency: 'fetchDatasetsWithCount'. Either include it or remove the dependency array
lint: src/sections/dataset/Dataset.tsx#L74
React Hook useEffect has missing dependencies: 'addDatasetAlert', 'created', 'datasetAlerts', 'navigate', 'publishInProgress', 'removeDatasetAlert', and 'setDatasetAlerts'. Either include them or remove the dependency array
lint: src/sections/dataset/dataset-alerts/DatasetAlerts.tsx#L14
React Hook useEffect has a missing dependency: 'addDatasetAlert'. Either include it or remove the dependency array
lint: src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts#L75
React Hook useEffect has a missing dependency: 'updateFileSelection'. Either include it or remove the dependency array
lint: src/sections/dataset/dataset-files/files-table/row-selection/useFileSelection.ts#L79
React Hook useEffect has missing dependencies: 'computeCurrentPageRowSelection' and 'setCurrentPageRowSelection'. Either include them or remove the dependency array. If 'setCurrentPageRowSelection' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: src/sections/dataset/dataset-files/useFiles.tsx#L75
React Hook useEffect has missing dependencies: 'getFiles' and 'getFilesCountInfo'. Either include them or remove the dependency array
lint: src/sections/shared/pagination/PaginationControls.tsx#L45
React Hook useEffect has missing dependencies: 'onPaginationInfoChange' and 'paginationInfo'. Either include them or remove the dependency array. If 'onPaginationInfoChange' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: src/sections/shared/pagination/PaginationControls.tsx#L55
React Hook useEffect has missing dependencies: 'onPaginationInfoChange', 'paginationInfo', 'searchParams', 'setSearchParams', and 'updateQueryParam'. Either include them or remove the dependency array. If 'onPaginationInfoChange' changes too often, find the parent component that defines it and wrap that definition in useCallback
lint: src/sections/shared/pagination/PaginationControls.tsx#L59
React Hook useEffect has a missing dependency: 'paginationInfo'. Either include it or remove the dependency array. You can also do a functional update 'setPaginationInfo(p => ...)' if you only need 'paginationInfo' in the 'setPaginationInfo' call