Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot deselect guestbook for a dataverse #2257

Closed
scolapasta opened this issue Jun 12, 2015 · 4 comments · Fixed by #8403
Closed

Cannot deselect guestbook for a dataverse #2257

scolapasta opened this issue Jun 12, 2015 · 4 comments · Fixed by #8403
Labels
Feature: Account & User Info Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Feature: Guestbook Help Wanted: Code Mentor: pdurbin Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone
5.10

Comments

@scolapasta
Copy link
Contributor

scolapasta commented Jun 12, 2015 •
edited by pdurbin

No description provided.

@scolapasta scolapasta added this to the Candidates for 4.0.2 milestone Jun 12, 2015
@scolapasta
Copy link
Contributor Author

Noticed by @bencomp during a demo.

@scolapasta scolapasta changed the title Cannot delselect guestbook for a dataverse Cannot deselect guestbook for a dataverse Jun 12, 2015
@bencomp
Copy link
Contributor

bencomp commented Jun 12, 2015

It appears that a guestbook is selected via a radio button instead of a checkbox. If there is just one guestbook, and it is selected, you cannot deselect it after saving.

@ghost ghost self-assigned this Jun 19, 2015
@scolapasta scolapasta unassigned ghost Jun 29, 2015
@scolapasta scolapasta modified the milestones: Candidates for 4.0.2, In Review Jul 2, 2015
@mheppler mheppler added Feature: Account & User Info Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... labels Jan 28, 2016
@eaquigley eaquigley added the UX & UI: Design This issue needs input on the design of the UI and from the product owner label Jan 28, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@mheppler
Copy link
Contributor

There is a "Clear Selection" button on the page (see attached), but the render logic for it is rendered="#{!empty DatasetPage.dataset.guestbook}" which only seems to render the button after you save, or preview (which triggers the blue spinner). I tried applying an AJAX behavior event of rowSelectRadio in the dataTable, to update the display of the button, but I was not able to get it to work.

screen shot 2016-02-16 at 3 18 29 pm

@bencomp
Copy link
Contributor

bencomp commented Feb 17, 2016

How about an default row "no guestbook" with its own radio?
In any case I don't think you want to trigger a server call before you save (like what happened in #2633 before requesting the actual download). Client-side JavaScript could do the same.

@pdurbin pdurbin added the User Role: Depositor Creates datasets, uploads data, etc. label Jul 4, 2017
@pdurbin pdurbin mentioned this issue Feb 7, 2022
Merged
@pdurbin pdurbin added this to the 5.10 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Account & User Info Feature: Dataverse General Info Edit dataverse > "General Information" > Name, Alias, Email, Metadata Fields, et al... Feature: Guestbook Help Wanted: Code Mentor: pdurbin Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Milestone
5.10
Development

Successfully merging a pull request may close this issue.

Fix guestbook clear selection button GlobalDataverseCommunityConsortium/dataverse
5 participants
@pdurbin @mheppler @bencomp @scolapasta @eaquigley