Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid log error message when not using Archiver #5590

Closed
qqmyers opened this issue Feb 28, 2019 · 3 comments
Closed

Avoid log error message when not using Archiver #5590

qqmyers opened this issue Feb 28, 2019 · 3 comments
Assignees
Milestone

Comments

@qqmyers
Copy link
Member

qqmyers commented Feb 28, 2019

if :ArchiverClassName is not set (the default case), things work, but the null classname results in a log message noting that an archiver class can't be loaded. There's no need for such a message - it just pollutes the log. I'll send a PR to suppress it.

@qqmyers
Copy link
Member Author

qqmyers commented Feb 28, 2019

Actually, this should only happen if an archiver workflow is set up, or if you call the submitToArchive api call, or with the new 'update current version' code in #5541, so it should not be affecting v4.11 users who haven't ever set up archiving (just @kcondon during his testing... sorry).

@qqmyers
Copy link
Member Author

qqmyers commented Feb 28, 2019

fixing in #5541...

@pdurbin
Copy link
Member

pdurbin commented Feb 28, 2019

I just moved this to QA since it's part of the pull request currently under test.

@kcondon kcondon self-assigned this Feb 28, 2019
@kcondon kcondon closed this as completed Feb 28, 2019
@djbrooke djbrooke added this to the 4.12 milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants