Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Replace - "...same file" validation error msg not displayed correctly #6468

Closed
jggautier opened this issue Dec 18, 2019 · 1 comment · Fixed by #6924
Closed

File Replace - "...same file" validation error msg not displayed correctly #6468

jggautier opened this issue Dec 18, 2019 · 1 comment · Fixed by #6924

Comments

@jggautier
Copy link
Contributor

On Dataverse 4.18.1, when I try to replace a file with another file that has the same content (same md5), I'm not immediately getting the error message that "You cannot replace a file with the exact same file.":

filereplacebug

There's no messaging that the replace didn't work or why.

But if I then try to replace the file with a file that does not have the same content, the replace succeeds, and the error message that should have appeared when the replace failed the first time appears here:

filereplacebug2

So it's like the error message for failed attempts only appears once a successful attempt as been made.

@mheppler mheppler changed the title As a depositor, I need to know why I can't replace a file with another file that has the same content File Replace - "...same file" validation error msg not displayed correctly Jan 16, 2020
@djbrooke djbrooke moved this from Ready 🙋 to IQSS Sprint 2/26 - 3/11 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Feb 26, 2020
@djbrooke djbrooke added the Small label Feb 26, 2020
@djbrooke djbrooke moved this from IQSS Sprint 2/26 - 3/11 to Ready 🙋 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Mar 11, 2020
@djbrooke
Copy link
Contributor

We expect this will be fixed by work in #4813/#6924. I'll add it to the "closes" there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants