Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Buttons - consolidate render logic #7006

Closed
sekmiller opened this issue Jun 22, 2020 · 2 comments
Closed

Download Buttons - consolidate render logic #7006

sekmiller opened this issue Jun 22, 2020 · 2 comments

Comments

@sekmiller
Copy link
Contributor

file-download-button-fragment.xhtml is where all of the code for rendering the download buttons on the Dataset Page (for each fileMetadata displayed in the files table) and the File landing page. The rendering is dependent on file type (with special handling for tabular files - a separate link for each format a user may download a tabular file), package files, etc. There is also separate handling for displaying buttons dependent on whether a popup for Terms of Use/Guestbook is required. There are also separate buttons on the file landing page for exporting file Citation info in various formats (bibTex, RIS, etc.)

The goal here would be to consolidate as much as possible especially with an eye toward bringing the File Page and Dataset Page rendering logic back together.

@mheppler
Copy link
Contributor

mheppler commented Aug 6, 2020

I believe this issue is a duplicate of an older issue, Download Permissions: Remove business logic from Application fragments. #2698. We should discuss the scope for this to make sure we cover all outstanding technical debt, and outline it here.

@djbrooke
Copy link
Contributor

@mheppler @scolapasta we discussed closing this in sprint planning as this is one of the steps in #7081 . I'll close this, and I'll close the suggested duplicate (#2698) as well. Feel free to reopen if this is incorrect.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Needs Discussion 💬 to Done 🚀 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants