Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential S3 resource leaks exposed by 5.1 #7309

Closed
qqmyers opened this issue Oct 7, 2020 · 0 comments · Fixed by #7313
Closed

Potential S3 resource leaks exposed by 5.1 #7309

qqmyers opened this issue Oct 7, 2020 · 0 comments · Fixed by #7313

Comments

@qqmyers
Copy link
Member

qqmyers commented Oct 7, 2020

The switch in v5.1 to use a single AWS client appears to have exposed some additional resource leaks /open connections to S3. One source of these may be some uses of Java Channels where the Channel is not closed. This issue is a placeholder for work to fix those leaks, check for others, and potentially to add some monitoring/retry capabilities to avoid situations where S3 connections fail (causing downloads as well as display of thumbnails, etc. to fail).
(Note #7308 increases the default pool size and makes it configurable. Setting the pool size to a larger value should help.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant