Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Institution name truncated in shibboleth login #7435

Closed
joe-programador opened this issue Nov 23, 2020 · 3 comments
Closed

Institution name truncated in shibboleth login #7435

joe-programador opened this issue Nov 23, 2020 · 3 comments
Assignees
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Account & User Info Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF Vote to Close: pdurbin

Comments

@joe-programador
Copy link

Grettings , in shibbolet login section exist a combobox id = "idpSelectSelector". Which allows to select the name of the Idp, however some names are truncated. What changes would be necessary for the full name to be displayed?

@pdurbin
Copy link
Member

pdurbin commented Nov 23, 2020

@joe-programador hi! I think you'd want to hack around with these files:

Screen Shot 2020-11-23 at 10 45 07 AM

@djbrooke
Copy link
Contributor

Hi @joe-programador, as @pdurbin mentions, there are some code changes that could be made to adjust this. Two things I wanted to ask/mention:

  • Can you talk about your need here? Is it cosmetic or is there some information at the end of the name that's being cut off and it's preventing the user from making the correct choice in the dropdown? Some screenshots would be helpful.
  • We are reviewing some ways to truncate longer fields throughout the application (Truncate methods: checksums, long summary metadata fields  #6685) and we would want to be consistent if we did truncate, so it is unlikely we would accept a PR for this until we were about to review it alongside other truncation needs in the application.

@pdurbin
Copy link
Member

pdurbin commented Oct 1, 2022

@joe-programador hi, just checking if you got a chance to hack around with those files. Thanks.

@pdurbin pdurbin added Type: Bug a defect Feature: Account & User Info Vote to Close: pdurbin User Role: Depositor Creates datasets, uploads data, etc. Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF labels Oct 8, 2023
@pdurbin pdurbin closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Account & User Info Type: Bug a defect User Role: Depositor Creates datasets, uploads data, etc. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF Vote to Close: pdurbin
Projects
None yet
Development

No branches or pull requests

4 participants