Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Improvements #8321

Closed
qqmyers opened this issue Dec 22, 2021 · 0 comments · Fixed by #8322
Closed

Accessibility Improvements #8321

qqmyers opened this issue Dec 22, 2021 · 0 comments · Fixed by #8322
Milestone

Comments

@qqmyers
Copy link
Member

qqmyers commented Dec 22, 2021

Overview of the Feature Request
QDR has been working to improve Accessibility in Dataverse, primarily using the Deque Axe plugin to identify issues. The changes made significantly reduce the number of issues reported. For example, the main page on demo.dataverse.org lists 89 issues whereas the main page of a test server with the updates reports only 26 issues and all of these appear to be spurious color contrast issues (Axe flags any elements where there is a gradient background or an overlapping element, even if the displayed contrast is OK). There are similar reductions in almost all pages.

A PR to follow.

Any related open or closed issues to this feature request?
There are a wide range of accessibility issues including #7523 which is broad. Earlier accessibility issues could be reviewed to see if they are still relevant after the changes included in the PR for this issue.

In general, testing with Axe involves having the page and/or pop-ups involved displayed, so it is easy to miss issues if you don't open a menu, are in a different state (logged in/out, edit versus create versus view modes, with/without custom header/footers, etc.

There are some issues that look to me like they are due to PrimeFaces problems that are not easy to solve without editing their classes, including:

  • Interactive controls must not be nested - issue with PrimeFaces tabs
  • ARIA hidden element must not contain focusable elements - PrimeFaces dismissable alert message
  • All page content should be contained by landmarks - PrimeFaces datepicker adds elements outside main content area and doesn't add a landmark role.
  • ARIA hidden element must not contain focusable elements - PrimeFaces selectCheckboxMenu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants