Import DDI dataset with Term of Use

[lubitchv]

It seems that importDDI API does not import terms of Use from XML.
Although there is a treatment for this section in ImportDDIServiceBean and it parses correctly input xml in processDataAccs,
dvDTO.setTermsOfUse(parseText(xmlr, "notes")) is not used, instead there is just parseText(xmlr, "notes"). Hence despite parsing the xml for terms of use, the terms never set.

What steps does it take to reproduce the issue?
Create import xml with
<dataAccs> <notes type="DVN:TOU" level="dv">Test</notes> </dataAccs>
in stdyDscr section.

curl -H X-Dataverse-key:$API_TOKEN -X POST http://localhost:8080/api/dataverses/:root/datasets/:importddi --upload-file test_term_of_use.xml

Example of such xml file is attached.

test_term_of_use.txt

[jggautier]

Hey @lubitchv. I would think the same is true for the Terms of Access field. Would you happen to know? If you're not sure either I can test this and create a separate GitHub issue for it.

[lubitchv]

In the code, Therms of Access field seems to be filled, it seems to be ok. It has

                if (NOTE_TYPE_TERMS_OF_ACCESS.equalsIgnoreCase(noteType) ) {
                    if (LEVEL_DV.equalsIgnoreCase(xmlr.getAttributeValue(null, "level"))) {
                        dvDTO.setTermsOfAccess(parseText(xmlr, "notes"));
                    }
                } 

so it should work, unlike term of use that was:

                if (NOTE_TYPE_TERMS_OF_USE.equalsIgnoreCase(noteType) ) {
                   if ( LEVEL_DV.equalsIgnoreCase(xmlr.getAttributeValue(null, "level"))) {
                        parseText(xmlr, "notes");
                    }
               }

[jggautier]

Ah great! Thanks!