bump sample heap size to something large enough for install process #9322
Conversation
… Dataverse install process
| @@ -4,7 +4,7 @@ GLASSFISH_USER = dataverse | |||
| GLASSFISH_DIRECTORY = /usr/local/payara5 | |||
| GLASSFISH_ADMIN_USER = admin | |||
| GLASSFISH_ADMIN_PASSWORD = secret | |||
| GLASSFISH_HEAP = 2048 | |||
| GLASSFISH_HEAP = 4096 | |||
There was a problem hiding this comment.
This might be a dumb question but is another option to remove this line? I thought the installer calculated the heap based on what's available, but I could be mistaken.
There was a problem hiding this comment.
I don't know about removing the line (since it's an available option) but if you'd like I can replace the longstanding sample value with a comment that says "set this to roughly half of the system RAM, in MB" or some such? I don't like hard-coding a value, either...
|
If you are still interested in this PR, can you please merge and resolve any merge conflicts with the latest from develop? If so, we can prioritize reviewing and QAing the changes. If we don’t hear from you by May 22, 2024, we’ll go ahead and close this PR (it can always be reopened after that date, if there is still interest). |
Closing. |
What this PR does / why we need it:
Install process was failing with database errors; succeeded once we bumped this value.
Which issue(s) this PR closes:
Closes #9321
Special notes for your reviewer:
None
Suggestions on how to test this:
Run the installer with the previous and proposed values
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None