Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable server-port-number for the containerized Dataverse #9534

Open
akio-sone opened this issue Apr 18, 2023 · 1 comment
Open

Configurable server-port-number for the containerized Dataverse #9534

akio-sone opened this issue Apr 18, 2023 · 1 comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: None No user-facing feature in particular Type: Bug a defect User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh

Comments

@akio-sone
Copy link
Contributor

The current port-number of the containerized Dataverse server is set to 8080 in docker-compose-dev.yml.

    ports:
      - "8080:8080" # HTTP (Dataverse Application)

Since the port-number 8080 is commonly used one and might be already preempted by another locally running container or web application, it is nice for developers to choose a non-8080 number.

Although it is easy to change the port number in docker-compose-dev.yml, the shell script file docker-final-setup.sh, which is executed after the Dataverse starts running in a container and calls its 3 child shell script files, have many hard-coded 8080s in it.
More specifically,

scripts/dev/docker-final-setup.sh calls scripts/api/setup-all.sh
scripts/api/setup-all.sh calls the following 3 shell script files whose contents are mostly API calls

scripts/api/setup-datasetfields.sh
scripts/api/setup-builtin-roles.sh 
scripts/api/setup-identity-providers.sh

While this issue could be solved in a limited scope, it might be better to handle this issue in a much broader context such as refactoring of the overall configuration steps.

@pdurbin
Copy link
Member

pdurbin commented Sep 7, 2023

@akio-sone now that #9574 has been merged, can you please try this again?

We also have a thread going here if you'd like to discuss there: https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/configurable.20ports

@pdurbin pdurbin added Type: Bug a defect User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: None No user-facing feature in particular labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Feature: None No user-facing feature in particular Type: Bug a defect User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
Status: No status
Development

No branches or pull requests

2 participants