Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Notes as a list #435 #480

Merged
merged 20 commits into from
Aug 15, 2019
Merged

Conversation

hopetambala
Copy link
Contributor

Description of proposed changes

What does this pr accomplish and why should it be integrated?
Adds the ability to hover over a note on a lists panel (on the left-hand side) and shows the corresponding note.

Checklist

_Put an x in the boxes that apply. _

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my changes work (if applicable)
  • I have added or updated necessary documentation (if appropriate)

Additional comments

Is there anything else you want us to know?
The notes state is brought down to d3-viz.js for a potential future implementation

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #480 into master will decrease coverage by 0.3%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage    82.8%   82.49%   -0.31%     
==========================================
  Files          29       29              
  Lines         849      857       +8     
==========================================
+ Hits          703      707       +4     
- Misses        146      150       +4
Impacted Files Coverage Δ
src/domain/notes.js 78.26% <50%> (-15.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e2148...80d344f. Read the comment docs.

@hopetambala
Copy link
Contributor Author

@rashley-iqt fixed merge conflict and added dark theme styling

@rashley-iqt rashley-iqt merged commit 1f27710 into IQTLabs:master Aug 15, 2019
@hopetambala hopetambala deleted the notes-as-a-list-#435 branch August 15, 2019 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants