This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Notes as a list #435 #480
Merged
rashley-iqt
merged 20 commits into
IQTLabs:master
from
hopetambala:notes-as-a-list-#435
Aug 15, 2019
Merged
Notes as a list #435 #480
rashley-iqt
merged 20 commits into
IQTLabs:master
from
hopetambala:notes-as-a-list-#435
Aug 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge remote into local
merge CRViz into local
merge crviz into local
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 82.8% 82.49% -0.31%
==========================================
Files 29 29
Lines 849 857 +8
==========================================
+ Hits 703 707 +4
- Misses 146 150 +4
Continue to review full report at Codecov.
|
@rashley-iqt fixed merge conflict and added dark theme styling |
rashley-iqt
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
What does this pr accomplish and why should it be integrated?
Adds the ability to hover over a note on a lists panel (on the left-hand side) and shows the corresponding note.
Checklist
_Put an
x
in the boxes that apply. _Additional comments
Is there anything else you want us to know?
The notes state is brought down to d3-viz.js for a potential future implementation