Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pci_flags_get() falsely checks the ECN flag #1324

Open
kristjoc opened this issue May 23, 2020 · 0 comments
Open

pci_flags_get() falsely checks the ECN flag #1324

kristjoc opened this issue May 23, 2020 · 0 comments

Comments

@kristjoc
Copy link
Contributor

There might exist a BUG in pdu_flags_get() and pdu_flags_set() functions, which I am not able to find it.
I am testing the RED congestion control policy using a simple topology: Cln -- R1 -- R2 -- Srv
All hosts are configured to use red-ps as the DTCP and RMT policy.

At dtcp-ps-red.c file, if (pci_flags_get(pci) & PDU_FLAGS_EXPLICIT_CONGESTION) returns True even though none of the hosts mark the PDU (red_action returns "RED_DONT_MARK" and "PDU_FLAGS_EXPLICIT_CONGESTION" is never set).
It seems like pci_flags_get() confirms the ECN flag even when the DRF bit is set, for instance.

Can you reproduce this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant