Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in display functions more gracefully and isolate full html pages #285

Merged
merged 5 commits into from
Mar 30, 2016
Merged

Handle errors in display functions more gracefully and isolate full html pages #285

merged 5 commits into from
Mar 30, 2016

Commits on Mar 30, 2016

  1. Handle errors in display functions more gracefully 

    Before, when one repr_xxx was raising an error, the complete display machinery
was impacted and no output was displayed. Now only the specific output is
omitted and a user friendly error message is shown on stderr and the stacktrace
(up to now pretty useless because it just shows one line) is shown on the
console.
    @jankatins
    jankatins committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    faf35cf View commit details
    Browse the repository at this point in the history

  2. Show proper stacktrace in the console on display error 

    Using withCallingHandlers gives a better stacktrace which shows the stacktrace
up to the place where the error is raised. Unfortunately, the error is not
caught, so wrap the thing in a tryCatch which just does nothing...
    @jankatins
    jankatins committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    30fd011 View commit details
    Browse the repository at this point in the history

  3. Send stacktrace on display error 

    Before, we only showed the error message, but no stacktrace in the notebook. The
stacktrace was shown in the console. Now it is shown in both.

This is in line what the IPython kernel does. We also now only display the
stacktrace for the method which does something wrong and not our internal
execution stuff...
    @jankatins
    jankatins committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    2948b01 View commit details
    Browse the repository at this point in the history

  4. Isolate full html pages in the frontend 

    Indicate that full html pages should be isolated in an iframe. Check if the html
is a complete document (contains html) and set the right metadata.
    @jankatins
    jankatins committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    f2a153d View commit details
    Browse the repository at this point in the history

  5. Add smoketests for the display system

    @jankatins
    jankatins committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    1b7d757 View commit details
    Browse the repository at this point in the history