Fix repr of list with identical(names(l), '')

IRkernel · Aug 19, 2020 · 9af4e98 · 9af4e98
1 parent 83c64b9
commit 9af4e98
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/R/repr_list.r b/R/repr_list.r
@@ -17,7 +17,9 @@ repr_list_generic <- function(
 	escape_fun = identity) {
 
 	nms <- names(vec)
-	if (!is.null(nms)) {
+	if (identical(nms, '')) {
+		nms <- NULL
+	} else if (!is.null(nms)) {
 		nms <- as.character(sapply(nms, as_name_or_na, USE.NAMES = FALSE))  # adds `` around special chars
 		nms <- escape_fun(nms)
 	}

diff --git a/tests/testthat/test_repr_list.r b/tests/testthat/test_repr_list.r
@@ -44,3 +44,11 @@ test_that('NAs can occur in list names', {
 </dl>
 ')
 })
+
+test_that('Lists with empty strings as names work', {
+	l <- structure(list(1), names = '')
+	expect_identical(repr_html(l), '<ol>
+\t<li>1</li>
+</ol>
+')
+})