Optimize has_row_names. Fixes #634

IRkernel · Jun 11, 2019 · d25aad0 · d25aad0 · flying-sheep · Dec 16, 2019
1 parent 593305c
commit d25aad0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/R/utils.r b/R/utils.r
@@ -143,8 +143,10 @@ data_uris <- function(..., mime = '', encoding = 'base64', files) {
 
 
 has_row_names <- function(x) {
-	rns <- rownames(x)
-	length(dim(x)) != 1 && length(rns) > 0 && !all(rns == seq_len(nrow(x))) && !all(rns == '')
+	if (is.data.frame(x))
+		.row_names_info(x) > 0
+	else
+		!is.null(rownames(x))
 }