Bug-fix in QA_CORDEX.cpp: test 16_12 not for cell_methods='time: point'

include/variable.h

@@ -98,6 +98,7 @@ class VariableMeta
   bool isFixed;  // isTime==false && isDataVar==true
   bool isFillValue;
   bool isFormulaTermsVar;
+  bool isInstant;
   bool isLabel;
   bool isMapVar;
   bool isMissingValue;

src/CF.cpp

@@ -7463,7 +7463,6 @@ CF::chap7_3(void)
     if( (jx=var.getAttIndex(n_cell_methods)) == -1 )
       continue;
 
-    // note that the loop is in fact gratuitous
     std::string cm ;
     for( size_t i=0 ; i < var.attValue[jx].size() ; ++i )
     {
@@ -7902,7 +7901,8 @@ CF::chap7_3_cellMethods_Method(std::string &str0, Variable& var)
   term.push_back("mid_range");
   term.push_back("minimum");
   term.push_back("mode");
-  term.push_back("point");
+  std::string point("point");
+  term.push_back(point);
   term.push_back("standard_deviation");
   term.push_back("sum");
   term.push_back("variance");
@@ -7928,6 +7928,11 @@ CF::chap7_3_cellMethods_Method(std::string &str0, Variable& var)
     return true;
   }
 
+  // a time-line of instant values without boundaries?
+  std::vector<std::string> x_m_Items(x_methods.getItems());
+  if( hdhC::isAmong(point, x_m_Items) && time_ix > -1 )
+    pIn->variable[time_ix].isInstant=true;
+
   // check valid mode
   if( x_methods.size() > 1 )
   {

src/QA_CORDEX.cpp

@@ -2778,7 +2778,7 @@ QA::checkVarTableEntry_standardName(
 {
   if( tbl_entry.standardName != vMD.var->std_name
         && vMD.var->name != "evspsblpot" )
-  {  // note that evspsblpot had a different "valid" name in a former
+  {  // note that evspsblpot is not a standard_name definded by CF conventions
      // CORDEX_variables_requirement table
     std::string key("32_2");
     if( notes->inq( key, vMD.var->name) )
@@ -5204,13 +5204,17 @@ QA::testPeriod(void)
     isLeft_fT_not_tV = *tV_left != *fN_left ;
     isRight_fT_not_tV = *tV_right != *fN_right ;
 
-    std::string key("16_12");
-    if( notes->inq( key, fVarname) )
+    if( qaTime.time_ix > -1 &&
+          ! pIn->variable[qaTime.time_ix].isInstant )
     {
-      std::string capt("Variable time_bnds is missing");
+      std::string key("16_12");
+      if( notes->inq( key, fVarname) )
+      {
+        std::string capt("Variable time_bnds is missing");
 
-      (void) notes->operate(capt) ;
-      notes->setCheckMetaStr( fail );
+        (void) notes->operate(capt) ;
+        notes->setCheckMetaStr(fail);
+      }
     }
   }
 

src/Variable.cpp

@@ -17,6 +17,7 @@ VariableMeta::VariableMeta()
   isFixed=false;
   isFillValue=false;
   isFormulaTermsVar=false;
+  isInstant=false;
   isLabel=false;
   isMapVar=false;
   isMissingValue=false;