Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Parameter Value selection in AssayGraph dict #333

Closed
proccaserra opened this issue Jun 13, 2019 · 0 comments
Closed

Allow Parameter Value selection in AssayGraph dict #333

proccaserra opened this issue Jun 13, 2019 · 0 comments
Assignees
Milestone

Comments

@proccaserra
Copy link
Member

considering an AssayGraph dictionary (e.g. ms_assay_dict as found in test_create_models_study_design.py), which defines protocol parameters, each with n options,
the code currently creates the cross-products over all values of each set.

improvement:
allow selection of a subset of value for each parameter, thus reducing the number of combinations.

template definition:
parameter=acquisition_mode, values = [positive mode, negative mode]
parameter=injection_mode, values = [FIA,GC,LC]
(current behaviour = create all possible combinations)

user setting for the assay plan:
parameter=acquisition mode, values = [positive mode]
parameter=injection_mode, values = [GC,LC]
(desirable behaviour = allow user to restrict the space to only those relevant to need)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants