Kotlin mutator testing #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant scala files
Many bugs fixed with tests not being run by maven Modified KotlinAST to fake immutability, I am pretty sure you can insert new elements into KtElements however this would change the hashCode of the AST and result in problems. Added more constructors for kotlin classes to support variety in used mutators
…tlin.test again instead of using jupyter)
# Conflicts: # stryker4jvm-mutator-kotlin/src/test/kotlin/stryker4jvm/mutator/kotlin/InstrumenterTest.kt
# Conflicts: # stryker4jvm-mutator-kotlin/src/main/kotlin/stryker4jvm/mutator/kotlin/KotlinInstrumenter.kt # stryker4jvm-mutator-kotlin/src/main/kotlin/stryker4jvm/mutator/kotlin/KotlinParser.kt
Circumvent is made because the current way of passing down a config makes it really hard to test individual components as they now all require a configuration. Would be better if they were passed to the constructor once (of the class that extends LanguageMutator) such that individual components do not depend on this configuration anymore (config can be used once and then discarded as classes should be initialized based on config) Fixed issue with stryker4jvm-core exception having multiple constructors
LvanArkel
reviewed
Dec 22, 2022
| plugins { | ||
| kotlin("jvm") //version "1.5.10" | ||
| kotlin("plugin.serialization") version "1.5.10" | ||
| kotlin("jvm") version "1.4.20" |
There was a problem hiding this comment.
Is a downgrade necessary here?
There was a problem hiding this comment.
yessir, that is the reason why we get runtime exceptions. Version 1.5 and above does not allow illegal reflections which stryker4k depends on
LvanArkel
reviewed
Dec 22, 2022
| @@ -45,4 +46,8 @@ class KotlinCollector : Collector<KotlinAST> { | |||
|
|
|||
| return res | |||
| } | |||
|
|
|||
| fun collect(tree: KotlinAST?): CollectedMutants<KotlinAST> { | |||
| return collect(tree, LanguageMutatorConfig(mutableSetOf())) | |||
There was a problem hiding this comment.
If you are not using the languageconfig, can't you leave it null and add a nullable to collect(tree, config)?
There was a problem hiding this comment.
you are right, I fogot about that because instead of compiler issues I was given a runtime exception because the private config variable of the base language mutator was null
There was a problem hiding this comment.
has now been changed
LvanArkel
reviewed
Dec 22, 2022
stryker4jvm-mutator-kotlin/src/main/kotlin/stryker4jvm/mutator/kotlin/KotlinInstrumenter.kt
Outdated
Show resolved
Hide resolved
LvanArkel
reviewed
Dec 22, 2022
stryker4jvm-mutator-kotlin/src/main/kotlin/stryker4jvm/mutator/kotlin/KotlinMutator.kt
Outdated
Show resolved
Hide resolved
LvanArkel
reviewed
Dec 22, 2022
stryker4jvm-mutator-kotlin/src/main/kotlin/stryker4jvm/mutator/kotlin/KotlinMutator.kt
Outdated
Show resolved
Hide resolved
LvanArkel
reviewed
Dec 22, 2022
stryker4jvm-mutator-kotlin/src/main/kotlin/stryker4jvm/mutator/kotlin/KotlinParser.kt
Outdated
Show resolved
Hide resolved
…ST but instead modifying the original. Note that it still modifies the original but that we wrap the resulting tree into a new AST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Testing for kotlin language specific implementation
How it works
Converted stryker4jvm-mutator-kotlin to gradle module to resolve runtime reflection issues.
Implemented tests for all components.
Currently circumvents config as the current design makes the testing of individual components a hassle
README
Do not forget to clean install stryker4jvm-core as well as doing a clean build with gradle for stryker4jvm-mutator-kotlin followed by a publishToMavenLocal!