Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stability volatge a macro #346

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Conversation

John-Holt-Tessella
Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella commented Jan 18, 2019

Description of work

Add stability voltage macro and set the default to 0.1V as seen in the Labview (adjusted from 1V originally).
Add settings for sweep and max field. Table created in https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/OxfordInstrumentsIPS.

To test

ISISComputingGroup/IBEX#2765

Acceptance criteria

  1. Stability voltage can be set as a macro
  2. Calc show stability voltage is set.

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants