LARMOR or ZOOM: Knauer HPLC 1050 IOC & OPI

[kjwoodsISIS]

As a scientist using LARMOR or ZOOM, I need a driver so that I can use a Knauer HPLC 1050 pump in my experiment.

Acceptance Criteria

1. Solution provide equivalent functionality to existing SECI VI.
2. Solution to be ready for Cycle 2018/03 (experiment is scheduled for 14th December).
3. I can control the Knauer HPLC 1050 pump from the IBEX GUI
4. I can control the Knauer HPLC 1050 pump from genie_python

Notes

1. LabVIEW VI for Knauer HPLC 1050 pump already exists:
   1. Front Panel VI: C:\LabVIEW Modules\Drivers\Knauer HPLC 1050\Knauer HPLC 1050 - System Functions.llb\Knauer HPLC 1050 - Front Panel 1.vi
   2. Setup Dialog: C:\LabVIEW Modules\Drivers\Knauer HPLC 1050\Knauer HPLC 1050 - System Functions.llb\Knauer HPLC 1050 - Setup Dialog.vi
   3. Documentation: `C:\LabVIEW Modules\Drivers\Knauer HPLC 1050\Documentation
2. Knauer HPLC 1050 appears to be a discontinued model. May need to rely on existing VI for logic and manual.
3. The work to be done for this ticket is as follows:
   1. Determine if support for Knauer HPLC 1050 pump can be implemented via lvDCOM.
      1. If so, do it (create appropriate XML file, front-panel OPI & setup dialog OPI)
      2. If not, proceed to next step.
   2. Examine existing VIs to discover which sub-set of commands are supported.
   3. Implement these as an IOC
   4. Create OPIs corresponding to the Front Panel & Setup Dialog.
4. Supporting the Knauer HPLC 1050 will also benefit other LSS instruments.
5. Background to experiment on LARMOR (or ZOOM).

[John-Holt-Tessella]

Confirm whether this is the right pump.

[FreddieAkeroyd]

Confirmed that this will be needed for NURF experiment in December

[GDH-ISIS]

May I raise a question with this - it might not be the correct device to develop initially. Sample environment LLS group have recently bought a Jasco HPLC pump. This JASCO might be a more appropriate initial development path for IBEX. I will try to get this confirmed.

[GDH-ISIS]

I have just confirmed with Rob that for the experiment in December, the driver for the Knauer HPLC 1050 is required.
(I should not have raised the question regarding the JASCO HPLC unit. A new ticket should be raised for the JASCO unit for use in the new year.)

[davidkeymer]

Main VI located here:
C:\LabVIEW Modules\Drivers\Knauer HPLC 1050\Knauer HPLC 1050 - System Functions.llb\Knauer HPLC 1050 - Front Panel 1.vi

[FreddieAkeroyd]

ORNL may have a driver, I've requested details

[aaron-long]

• Initial db and proto. EPICS-Knr1050#1
• https://github.com/ISISComputingGroup/EPICS/pull/144
• Ticket3262 add ioc knr1050 EPICS-IOC_Test_Framework#135
• Ticket3262 add ioc knr1050 EPICS-DeviceEmulator#5
• Ticket3262 add ioc knr1050 EPICS-ioc#336
• Ticket3262 add ioc knr1050 ibex_gui#834

[GDH-ISIS]

I have confirmed that for the experiment in December 2018, the Knauer switch valve is NOT required.

[ThomasLohnert]

Good work! IOC works well as far as I can tell. Changes are already merged as it is needed on the instrument and rework is not critical for functionality, but here are some suggestions for minor changes and general tidying up:

• Split start/stop toggle button into two buttons and disable "Start" when you cannot actually start the IOC (when it is in local mode or has wrong sum of concentrations)
• Add a readback label for sum of concentrations
• Rename "Run Control" widget group to "Pump Control" (Run control has a specific meaning in IBEX)
• Rename "Start Ramp" to "Start Pump" - makes the purpose clearer for the user
• Make more clear to the user that the gradient concentrations are set when starting the pump, e.g. by adding a label that says this, or descriptive column headers for the different values.
• Typo in label: "Gradiant A" -> "Gradient A"
• Open a new ticket for adding missing controls from the VI
• OPI Checker is complaining, fix as appropriate
• ibex_gui PR is missing
• The OPI Target appears as "KNR1050" in the list - alias this to "Knauer 1050 HPLC pump" in line with the rest of the OPIs
• Some more inline comments on individual PRs
  • Initial db and proto. EPICS-Knr1050#1
  • Ticket3262 add ioc knr1050 EPICS-ioc#336

[aaron-long]

New pull requests based on rework:

• Ticket3262: Updated config to have clear description and second ioc redirect. EPICS-ioc#340
• Ticket3262 add ioc knr1050 EPICS-IOC_Test_Framework#135
• Ticket3262 add ioc knr1050 EPICS-DeviceEmulator#5
• Ticket3262: Redesign of the Knauer db file. EPICS-Knr1050#2
• Ticket3262: Corrected target description. Redesigned opi for clarity. ibex_gui#836