Ticket3262: Corrected target description. Redesigned opi for clarity.

[aaron-long]

Description of work

Rework based on the linked ticket.

• Updated the target description in the opi_info.xml since it was unchanged from the default template
• Redesigned the OPI for clarity:
  -- Start/Stop button seperated
  -- New user messages under flowrate and gradient controls
  -- Redesigned the layout of the gradient control, including read backs and current device values
  -- New current mode readout

Ticket

Fixes: ISISComputingGroup/IBEX#3262

Acceptance criteria

OPI has been checked against the opi checker. 3 fails are observed but are by design:

• 2 x messages for the user
• 1 x Title label is not sentence case due to literal device name

Unit tests

None

System tests

None

Documentation

Knauer 1050 HPLC wiki entry updated.

Code Review

• Is the code of an acceptable quality?
• Do the changes function as described and is it robust?
• Have the changes been documented in the release notes?

Final Steps

• Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

[ghost]

Things to consider for next time:

• Current mode should just be Mode or Active Mode.
• Pump Running can be just Running.
• You don't need Control at the end of each title as IBEX is a control system.
• Use RBV, Readback or Value instead of current.
• Include the warning text within the group containers.
• Nitpick: Put Start button on the left of Stop.

[ghost]

The type should be changed to pump.

[ghost]

Flash reviewed by @John-Holt-Tessella